Skip to content
This repository was archived by the owner on Dec 13, 2023. It is now read-only.

Add prefers-color-scheme variant - #82

Open
arzafran wants to merge 2 commits into
wilfredwee:masterfrom
arzafran:master
Open

Add prefers-color-scheme variant#82
arzafran wants to merge 2 commits into
wilfredwee:masterfrom
arzafran:master

Conversation

@arzafran

@arzafran arzafran commented Nov 10, 2019

Copy link
Copy Markdown

Fixes #62 :)

wilfredwee
wilfredwee reviewed Nov 13, 2019
View reviewed changes
Comment thread userChrome-default.css

.tabbrowser-tab[pinned="true"][style^="margin-inline-start"] {
padding-left: 12px !important;
padding-left: 8px !important;

@wilfredwee wilfredwee Nov 13, 2019

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look to be separate from supporting theme-detection. I'll give them a try and see if these numbers work.

@arzafran arzafran Nov 13, 2019

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, I've added it to center the icons on pinned tabs:
Screen Shot 2019-11-13 at 16 35 02

wilfredwee
wilfredwee suggested changes Nov 13, 2019
View reviewed changes

@wilfredwee wilfredwee left a comment •
edited
Loading

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the PR! Sorry for the late review, life's been busy.

It looks like you're using a formatter. Could you submit either another PR or a change that formats the 2-other files too? This will make future changes easier.

@arzafran

arzafran commented Nov 13, 2019 •
edited
Loading

Copy link
Copy Markdown
Author

Thanks a lot for the PR! Sorry for the late review, life's been busy.

It looks like you're using a formatter. Could you submit either another PR or a change that formats the 2-other files too? This will make future changes easier.

Just did in the last PR.

btw, don't be sorry! I'm thankful you did all the heavy lifting allowing me to build upon your work a perfect theme for FF 😍

Have a nice week!

@arzafran

arzafran commented Nov 13, 2019 •
edited
Loading

Copy link
Copy Markdown
Author

just realized that having it to auto detect macOS dark preference having 'dark' and 'light' modes seems redundant..
Maybe it can also make maintenance/documentation/theming easier.

@arzafran
arzafran requested a review from wilfredwee November 13, 2019 19:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@wilfredwee wilfredwee Awaiting requested review from wilfredwee

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Default theme does not work in MacOS dark mode

3 participants

@arzafran @wilfredwee @Francam94